Fixed an issue where comments in manifest would make install fail#5380
Merged
david-poindexter merged 2 commits intodnnsoftware:developfrom Nov 8, 2022
Merged
Fixed an issue where comments in manifest would make install fail#5380david-poindexter merged 2 commits intodnnsoftware:developfrom
david-poindexter merged 2 commits intodnnsoftware:developfrom
Conversation
bdukes
approved these changes
Nov 8, 2022
mitchelsellers
approved these changes
Nov 8, 2022
david-poindexter
approved these changes
Nov 8, 2022
Contributor
david-poindexter
left a comment
There was a problem hiding this comment.
Excellent catch!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a package manifest would have a comment on the level of the first node, the installer would try to parse the comment instead of the real non-comment node.
0f60ce3 Fixes the actual issue and
50bb9e9 just cleans-ups the file a bit and adds some documentation