Upgrade Newtonsoft.Json to 13.0.1#5168
Merged
mitchelsellers merged 2 commits intodnnsoftware:release/9.11.0from Jul 5, 2022
Merged
Upgrade Newtonsoft.Json to 13.0.1#5168mitchelsellers merged 2 commits intodnnsoftware:release/9.11.0from
mitchelsellers merged 2 commits intodnnsoftware:release/9.11.0from
Conversation
david-poindexter
approved these changes
Jun 28, 2022
Contributor
david-poindexter
left a comment
There was a problem hiding this comment.
Looks great @bdukes - THANK YOU! 🎉
Looks like the build is delayed a bit in running - still in queue. So, barring no build issues, this looks good to me.
This was referenced Jun 28, 2022
Closed
Bump Newtonsoft.Json from 10.0.3 to 13.0.1 in /DNN Platform/Tests/DotNetNuke.Tests.Integration
#5148
Closed
Closed
Closed
mitchelsellers
approved these changes
Jun 28, 2022
This was referenced Jun 28, 2022
This was referenced Jun 28, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR upgrades DNN's dependency on Newtonsoft.Json from 10.x to 13.0.1.
This includes the following changes from their changelog:
ISerializablebut don't have[SerializableAttribute]are not serialized usingISerializableJsonProperty.MemberConverterto obsoleteEnumMemberAttributeJTokenReadernow usesJsonReader.DateTimeZoneHandlingsetting for date valuesTargetSitewhen serializing Exceptions withoutSerializableAttributeStringEnumConverter.ctor(bool camelCaseText)to obsoleteStringEnumConverter.CamelCaseTextto obsoleteJsonReaderandJsonSerializerMaxDepthdefaults to 64