Skip to content

[Bug]: New styles css variables settings missing prefix #6296

@valadas

Description

@valadas

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

The styles for each portal are stored in the PortalSettings table but currently the name only uses the css variable name which could be generic enough to potentially conflict with 3rd party existing setting names (if they also did not use a prefix).

Steps to reproduce?

  1. View the PortalSettings table
  2. Notice the settings name are not prefixed

Current Behavior

If a third party also uses portal level settings such as BaseFontSize, it would conflict with ours.

Expected Behavior

Settings should have a prefix, this is more true for 3rd-party extensions but I have seen it not done often enough that we should try and avoid it.

Relevant log output

No response

Anything else?

I am proposing we prefix them with DnnCssVar_ which as a bonus makes it easy to select them all in a query.

Affected Versions

10.0.0 (alpha)

What browsers are you seeing the problem on?

Chrome

Code of Conduct

  • I agree to follow this project's Code of Conduct

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions