Ensure no expression-bodies properties in DTO objects

donker · bdukes · commit 40b2a89a139d · 2020-11-16T14:52:48.000-06:00
diff --git a/Dnn.AdminExperience/Dnn.PersonaBar.Extensions/Components/Users/Dto/UserBasicDto.cs b/Dnn.AdminExperience/Dnn.PersonaBar.Extensions/Components/Users/Dto/UserBasicDto.cs
@@ -32,11 +32,12 @@ public UserBasicDto(UserInfo user)
             this.HasAgreedToTerms = user.HasAgreedToTerms;
             this.RequestsRemoval = user.RequestsRemoval;
             this.IsSuperUser = user.IsSuperUser;
-            this.IsAdmin = user.Roles.Contains(this.PortalSettings.AdministratorRoleName);
+            this.IsAdmin = user.Roles.Contains(this.PortalSettings.AdministratorRoleName);
+            this.AvatarUrl = Utilities.GetProfileAvatar(this.UserId);
         }
 
         [DataMember(Name = "avatar")]
-        public string AvatarUrl => Utilities.GetProfileAvatar(this.UserId);
+        public string AvatarUrl { get; set; }
 
         [DataMember(Name = "userId")]
         public int UserId { get; set; }
diff --git a/Dnn.AdminExperience/Dnn.PersonaBar.Extensions/Components/Users/Dto/UserDetailDto.cs b/Dnn.AdminExperience/Dnn.PersonaBar.Extensions/Components/Users/Dto/UserDetailDto.cs
@@ -48,14 +48,16 @@ public UserDetailDto(UserInfo user) : base(user)
                 this.HasUserFiles = files.Any();
             }
 
-            this.HasAgreedToTermsOn = user.HasAgreedToTermsOn;
+            this.HasAgreedToTermsOn = user.HasAgreedToTermsOn;
+            this.ProfileUrl = this.UserId > 0 ? Globals.UserProfileURL(this.UserId) : null;
+            this.EditProfileUrl = this.UserId > 0 ? GetSettingUrl(this.PortalId, this.UserId) : null;
         }
 
         [DataMember(Name = "profileUrl")]
-        public string ProfileUrl => this.UserId > 0 ? Globals.UserProfileURL(this.UserId) : null;
+        public string ProfileUrl { get; set; }
 
         [DataMember(Name = "editProfileUrl")]
-        public string EditProfileUrl => this.UserId > 0 ? GetSettingUrl(this.PortalId, this.UserId) : null;
+        public string EditProfileUrl { get; set; }
 
         [DataMember(Name = "lastLogin")]
         public DateTime LastLogin { get; set; }
