fix: race condition in EnumWrappers#initialize#3121
Merged
dmulloy2 merged 1 commit intodmulloy2:masterfrom Jul 23, 2024
Merged
Conversation
dmulloy2
approved these changes
Jul 23, 2024
Adds synchronization primitives inside the initialization function to ensure that when the function returns, everything is guaranteed to be initialized. Fixes dmulloy2#3120
529e55f to
6768cf2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds synchronization primitives inside the initialization function to ensure that when the function returns, everything is guaranteed to be initialized.
Fixes #3120
Most of the diff is just indenting the code that was already there. If you prefer, I can make a second function instead to avoid changing so many lines.
I've also opted by this approach instead of just adding
synchronizedto the method declaration because that would force synchronization well after everything has been initialized, reducing parallelization (and therefore performance).The new
INITIALIZINGvariable is necessary because certain function calls insideinitializealso callinitializethemselves, so movingINITIALIZED = trueto the end of the method would enter infinite recursion.