[#2980] Fix dropping of outbound configuration packets if sync processed#2982
Merged
dmulloy2 merged 1 commit intodmulloy2:masterfrom Jun 6, 2024
Conversation
dmulloy2
approved these changes
Jun 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our current implementation, asnc packet calls are rescheduled to the main thread using the
PlayerConnection::sendmethod. However, this approach relies on the PlayerConnection being defined, which only occurs after the initial configuration phase is complete. This PR addresses a scenario where thePlayerConnectionmight benullduring this initial phase. To handle such cases we now invoke theNetworkManagerdirectly to skip thePlayerConnection.closes #2980