Fixed Listening to Handshake Packets & ServerPingRecord#2933
Merged
dmulloy2 merged 1 commit intodmulloy2:masterfrom Jun 3, 2024
Merged
Fixed Listening to Handshake Packets & ServerPingRecord#2933dmulloy2 merged 1 commit intodmulloy2:masterfrom
dmulloy2 merged 1 commit intodmulloy2:masterfrom
Conversation
Ingrim4
reviewed
May 16, 2024
| .build()); | ||
|
|
||
| BiFunction<Channel, PacketType.Sender, Object> baseResolver = null; | ||
| BiFunction<Channel, PacketType.Sender, PacketType.Protocol> baseResolver = null; |
Collaborator
There was a problem hiding this comment.
Why change the type here from Object to PacketType.Protocol? Doesn't this only introduce duplicate code since you copied the PacketType.Protocol::fromVanilla method to the resolver implementations?
Contributor
Author
There was a problem hiding this comment.
It does create some duplication but as PacketType.Protocol::fromVanilla isn't used everywhere anymore after this change with some cases returning the the packet type directly, I felt like it made sense to make the function return the type directly.
This was referenced May 24, 2024
dmulloy2
approved these changes
Jun 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On version 1.20.6,
ChannelProtocolUtilis unable to get the Handshake Protocol PacketType due to Minecraft using a different handler during this phase.ServerPingRecordis also unable to locate the server icon class on Mojang-mapped servers.Fixes #2647