You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adds support for minecraft 1.20.5 (missing new packet types as of now). To be honest I have no idea how updates for ProtocolLib are usually done regarding PacketTypes so this PR will only fix the new packet id system and some minor issues that occurred while testing 1.20.5.
I found a packet error with 1.20.5, I saw that the com.comphenix.protocol.wrappers.WrappedLevelChunkData$ChunkData class cannot be initialized because the constructor for the real packet changed.
On 1.20.4 it was public ClientboundLevelChunkPacketData(PacketDataSerializer packetdataserializer, int i, int j)
Now it's public ClientboundLevelChunkPacketData(RegistryFriendlyByteBuf registryfriendlybytebuf, int i, int j)
I found a packet error with 1.20.5, I saw that the com.comphenix.protocol.wrappers.WrappedLevelChunkData$ChunkData class cannot be initialized because the constructor for the real packet changed. On 1.20.4 it was public ClientboundLevelChunkPacketData(PacketDataSerializer packetdataserializer, int i, int j) Now it's public ClientboundLevelChunkPacketData(RegistryFriendlyByteBuf registryfriendlybytebuf, int i, int j)
Oh I didn't notice the new RegistryFriendlyByteBuf that will need some major rework of the packet wrapper system since a bunch of packets require this new derivative to even read/create a new packet. I will look into it once I'm back from vacation. I would probably just use the new MinecraftRegistryAccess class from this PR for the registry accessor and rewrite some parts of the StructureCache to work with the new class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for minecraft 1.20.5 (missing new packet types as of now). To be honest I have no idea how updates for ProtocolLib are usually done regarding PacketTypes so this PR will only fix the new packet id system and some minor issues that occurred while testing 1.20.5.
Related Issue
closes #2893
closes #2896
How Has This Been Tested?
Tested with latest spigot 1.20.5 and 1.20.4 build with an early build of orebfuscator for 1.20.5. I couldn't observe any obvious errors.
Types of Changes
P.S. could someone please also review my other fix: #2545