Fix async handler scheduler support for folia#2531
Merged
dmulloy2 merged 2 commits intodmulloy2:masterfrom Oct 25, 2023
Merged
Conversation
dmulloy2
approved these changes
Oct 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When utilizing ProtocolLib within a server powered by Folia that employs asynchronous listeners, invoking the
startmethod of anAsyncListenerHandlerwill use the default Bukkit scheduler. This will throw an exception since the Bukkit scheduler got replaced by multiple scheduler instances in Folia. This PR should fix this behavior though using theAsyncSchedulerif Folia is present.