Fixed PING packet for 1.19.1 and 1.19.2#2518
Merged
dmulloy2 merged 1 commit intodmulloy2:masterfrom Aug 26, 2023
Fanfaryy:fixed_clientboundpingpacket
Merged
Fixed PING packet for 1.19.1 and 1.19.2#2518dmulloy2 merged 1 commit intodmulloy2:masterfrom Fanfaryy:fixed_clientboundpingpacket
dmulloy2 merged 1 commit intodmulloy2:masterfrom
Fanfaryy:fixed_clientboundpingpacket
Conversation
…and 1.19.2 versions with PING
dmulloy2
approved these changes
Aug 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the bug
When using PacketType.Play.Server.PING on versions using protocol number 760 (1.19.1, 1.19.2) it uses ClientboundPlayerChatHeaderPacket instead of ClientboundPingPacket due to using the same currentId on PING and deprecated PLAYER_CHAT_HEADER.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
PacketType.Play.Server.PING should use ClientboundPingPacket.
Screenshots
Before changing currentId of PLAYER_CHAT_HEADER:
After changing currentId of PLAYER_CHAT_HEADER:
Version Info
Before changing currentId of PLAYER_CHAT_HEADER:
https://pastebin.com/HBC3FW6D
After changing currentId of PLAYER_CHAT_HEADER:
https://pastebin.com/dEc91hxq
Additional context
In other versions it seems to work fine, but 1.19.1 and 1.19.2 is problematic.