Update to 1.20 by lukalt · Pull Request #2420 · dmulloy2/ProtocolLib

lukalt · 2023-06-07T17:43:36Z

Update ProtocolLib to 1.20.

These changes have been tested on Spigot 1.20, Paper 1.19.4, and Spigot 1.8.8.

Basically all required converters and structures have been tested on 1.20 using external unit tests (see https://github.com/lukalt/PacketWrapper/tree/master/src/test/java/com/comphenix/packetwrapper).

LOOHP · 2023-06-07T22:27:27Z

I seem to be getting this error using this PR during server start on SpigotMC 1.20

[23:25:29] [Server thread/ERROR]: net/bytebuddy/dynamic/scaffold/subclass/ConstructorStrategy initializing ProtocolLib v5.2.0-SNAPSHOT (Is it up to date?)
java.lang.NoClassDefFoundError: net/bytebuddy/dynamic/scaffold/subclass/ConstructorStrategy
	at com.comphenix.protocol.ProtocolLib.onLoad(ProtocolLib.java:125) ~[?:?]
	at org.bukkit.craftbukkit.v1_20_R1.CraftServer.loadPlugins(CraftServer.java:435) ~[spigot-1.20-R0.1-SNAPSHOT.jar:3766-Spigot-81b9def-a345bb9]
	at net.minecraft.server.dedicated.DedicatedServer.e(DedicatedServer.java:219) ~[spigot-1.20-R0.1-SNAPSHOT.jar:3766-Spigot-81b9def-a345bb9]
	at net.minecraft.server.MinecraftServer.w(MinecraftServer.java:973) ~[spigot-1.20-R0.1-SNAPSHOT.jar:3766-Spigot-81b9def-a345bb9]
	at net.minecraft.server.MinecraftServer.lambda$0(MinecraftServer.java:304) ~[spigot-1.20-R0.1-SNAPSHOT.jar:3766-Spigot-81b9def-a345bb9]
	at java.lang.Thread.run(Thread.java:833) ~[?:?]
Caused by: java.lang.ClassNotFoundException: net.bytebuddy.dynamic.scaffold.subclass.ConstructorStrategy
	at org.bukkit.plugin.java.PluginClassLoader.loadClass0(PluginClassLoader.java:147) ~[spigot-api-1.20-R0.1-SNAPSHOT.jar:?]
	at org.bukkit.plugin.java.PluginClassLoader.loadClass(PluginClassLoader.java:99) ~[spigot-api-1.20-R0.1-SNAPSHOT.jar:?]
	at java.lang.ClassLoader.loadClass(ClassLoader.java:520) ~[?:?]
	... 6 more

lukalt · 2023-06-07T22:29:33Z

@LOOHP This happened to me as well. You need to use the build/libs/ProtocolLib.jar rather than build/libs/ProtocolLib-5.2.0-SNAPSHOT.jar. The latter one does not include the shadowed dependencies.

LOOHP · 2023-06-08T01:41:21Z

Got it. Now it's working most of the time. However, weirdly sometimes when I boot up the server, it might fail with this error.

[02:38:53] [Server thread/ERROR]: Cannot invoke "com.comphenix.protocol.ProtocolConfig.isChatWarnings()" because the return value of "com.comphenix.protocol.ProtocolLibrary.getConfig()" is null initializing ProtocolLib v5.2.0-SNAPSHOT (Is it up to date?)
java.lang.NullPointerException: Cannot invoke "com.comphenix.protocol.ProtocolConfig.isChatWarnings()" because the return value of "com.comphenix.protocol.ProtocolLibrary.getConfig()" is null
	at com.comphenix.protocol.error.DetailedErrorReporter.reportDetailed(DetailedErrorReporter.java:394) ~[?:?]
	at com.comphenix.protocol.error.DelegatedErrorReporter.reportDetailed(DelegatedErrorReporter.java:63) ~[?:?]
	at com.comphenix.protocol.error.DelegatedErrorReporter.reportDetailed(DelegatedErrorReporter.java:87) ~[?:?]
	at com.comphenix.protocol.ProtocolLib.onLoad(ProtocolLib.java:186) ~[?:?]
	at org.bukkit.craftbukkit.v1_20_R1.CraftServer.loadPlugins(CraftServer.java:435) ~[spigot-1.20-R0.1-SNAPSHOT.jar:3766-Spigot-81b9def-a345bb9]
	at net.minecraft.server.dedicated.DedicatedServer.e(DedicatedServer.java:219) ~[spigot-1.20-R0.1-SNAPSHOT.jar:3766-Spigot-81b9def-a345bb9]
	at net.minecraft.server.MinecraftServer.w(MinecraftServer.java:973) ~[spigot-1.20-R0.1-SNAPSHOT.jar:3766-Spigot-81b9def-a345bb9]
	at net.minecraft.server.MinecraftServer.lambda$0(MinecraftServer.java:304) ~[spigot-1.20-R0.1-SNAPSHOT.jar:3766-Spigot-81b9def-a345bb9]
	at java.lang.Thread.run(Thread.java:833) ~[?:?]

lukalt · 2023-06-08T09:01:33Z

@LOOHP This was not caused by my changes but @dmulloy2 fixed it in the last commit

lukalt · 2023-06-08T13:52:38Z

@dmulloy2 thx, I implemented your suggestions

metabrixkt · 2023-06-10T14:32:22Z

Still randomly fails to load with the following error:

[17:23:39 INFO]: [ProtocolLib] Loading server plugin ProtocolLib v5.1.0-SNAPSHOT
[17:23:39 WARN]: [ProtocolLib] Version (MC: 1.20.0) has not yet been tested! Proceed with caution.
[17:23:40 ERROR]: [ProtocolLib] Error initializing plugin 'ProtocolLib.jar' in folder 'plugins' (Is it up to date?)
java.lang.NullPointerException: Cannot invoke "com.comphenix.protocol.ProtocolConfig.isChatWarnings()" because the return value of "com.comphenix.protocol.ProtocolLibrary.getConfig()" is null
        at com.comphenix.protocol.error.DetailedErrorReporter.reportDetailed(DetailedErrorReporter.java:394) ~[ProtocolLib.jar:?]
        at com.comphenix.protocol.error.DelegatedErrorReporter.reportDetailed(DelegatedErrorReporter.java:63) ~[ProtocolLib.jar:?]
        at com.comphenix.protocol.error.DelegatedErrorReporter.reportDetailed(DelegatedErrorReporter.java:87) ~[ProtocolLib.jar:?]
        at com.comphenix.protocol.ProtocolLib.onLoad(ProtocolLib.java:186) ~[ProtocolLib.jar:?]
        at io.papermc.paper.plugin.storage.ServerPluginProviderStorage.processProvided(ServerPluginProviderStorage.java:59) ~[satellite-1.20.jar:git-Satellite-"c69f4fb"]
        at io.papermc.paper.plugin.storage.ServerPluginProviderStorage.processProvided(ServerPluginProviderStorage.java:18) ~[satellite-1.20.jar:git-Satellite-"c69f4fb"]
        at io.papermc.paper.plugin.storage.SimpleProviderStorage.enter(SimpleProviderStorage.java:40) ~[satellite-1.20.jar:git-Satellite-"c69f4fb"]
        at io.papermc.paper.plugin.entrypoint.LaunchEntryPointHandler.enter(LaunchEntryPointHandler.java:36) ~[satellite-1.20.jar:git-Satellite-"c69f4fb"]
        at org.bukkit.craftbukkit.v1_20_R1.CraftServer.loadPlugins(CraftServer.java:451) ~[satellite-1.20.jar:git-Satellite-"c69f4fb"]
        at net.minecraft.server.dedicated.DedicatedServer.initServer(DedicatedServer.java:305) ~[satellite-1.20.jar:git-Satellite-"c69f4fb"]
        at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1119) ~[satellite-1.20.jar:git-Satellite-"c69f4fb"]
        at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:324) ~[satellite-1.20.jar:git-Satellite-"c69f4fb"]
        at java.lang.Thread.run(Thread.java:833) ~[?:?]

Running a private Purpur fork that does not introduce any changes that could possibly affect ProtocolLib

CrazyCraft88 · 2023-12-05T13:01:59Z

Hi Guys ehm your plugin dosnt Work:

[00:01:07] [Server thread/INFO]: [ProtocolLib] Loading ProtocolLib v5.1.0

[00:01:07] [Server thread/WARN]: [ProtocolLib] Version (MC: 1.20.2) has not yet been tested! Proceed with caution.

[00:01:08] [Server thread/ERROR]: [ProtocolLib] INTERNAL ERROR: Cannot load ProtocolLib.
If this problem hasn't already been reported, please open a ticket
at https://github.com/dmulloy2/ProtocolLib/issues with the following data:
Stack Trace:
java.lang.IllegalArgumentException: Unable to find a field that matches {modifiers=[required: 10000, banned: 1000], type={ type input instanceof interface java.util.Map }}
at com.comphenix.protocol.reflect.FuzzyReflection.getField(FuzzyReflection.java:352)
at com.comphenix.protocol.injector.packet.PacketRegistry.createNewRegister(PacketRegistry.java:188)
at com.comphenix.protocol.injector.packet.PacketRegistry.initialize(PacketRegistry.java:292)
at com.comphenix.protocol.injector.packet.PacketRegistry.getClientPacketTypes(PacketRegistry.java:327)
at com.comphenix.protocol.injector.PacketFilterManager.<init>(PacketFilterManager.java:120)
at com.comphenix.protocol.injector.PacketFilterBuilder.build(PacketFilterBuilder.java:121)
at com.comphenix.protocol.ProtocolLib.onLoad(ProtocolLib.java:183)
at org.bukkit.craftbukkit.v1_20_R2.CraftServer.loadPlugins(CraftServer.java:442)
at net.minecraft.server.dedicated.DedicatedServer.e(DedicatedServer.java:219)
at net.minecraft.server.MinecraftServer.w(MinecraftServer.java:954)
at net.minecraft.server.MinecraftServer.lambda$0(MinecraftServer.java:298)
at java.base/java.lang.Thread.run(Thread.java:840)
Dump:
Parameters:
[NULL]
Sender:
com.comphenix.protocol.ProtocolLib@358a6b2d[
statistics=<null>
packetTask=<null>
tickCounter=0
configExpectedMod=-1
updater=com.comphenix.protocol.updater.SpigotUpdater@686122c9
redirectHandler=<null>
scheduler=com.comphenix.protocol.scheduler.DefaultScheduler@5f985ce6
commandProtocol=<null>
commandPacket=<null>
commandFilter=<null>
packetLogging=<null>
skipDisable=false
isEnabled=false
loader=org.bukkit.plugin.java.JavaPluginLoader@c44e2e6
server=CraftServer{serverName=CraftBukkit,serverVersion=3949-Spigot-2888990-e54f39a,minecraftVersion=1.20.2}
file=plugins/ProtocolLib.jar
description=org.bukkit.plugin.PluginDescriptionFile@b6723bd
dataFolder=plugins/ProtocolLib
classLoader=org.bukkit.plugin.java.PluginClassLoader@46306767
naggable=true
newConfig=YamlConfiguration[path='', root='YamlConfiguration']
configFile=plugins/ProtocolLib/config.yml
logger=org.bukkit.plugin.PluginLogger@3dfdb2af
]
Version:
ProtocolLib v5.1.0
Java Version:
17.0.9
Server:
3949-Spigot-2888990-e54f39a (MC: 1.20.2)

Is there another update coming, right?

Weill various plugins don't work :S

Please answer me thx

0utplay reviewed Jun 8, 2023

View reviewed changes

Comment thread src/main/java/com/comphenix/protocol/wrappers/WrappedLevelChunkData.java Outdated

dmulloy2 reviewed Jun 8, 2023

View reviewed changes

Comment thread build.gradle

Comment thread src/main/java/com/comphenix/protocol/wrappers/WrappedLevelChunkData.java Outdated

Comment thread src/test/java/com/comphenix/protocol/PacketTypeTest.java Outdated

dmulloy2 force-pushed the 1.20 branch from e42c26d to 6542f09 Compare June 8, 2023 13:08

derklaro reviewed Jun 8, 2023

View reviewed changes

Comment thread src/main/java/com/comphenix/protocol/wrappers/WrappedLevelChunkData.java Outdated

derklaro reviewed Jun 9, 2023

View reviewed changes

Comment thread src/main/java/com/comphenix/protocol/wrappers/WrappedLevelChunkData.java

dmulloy2 previously approved these changes Jun 10, 2023

View reviewed changes

dmulloy2 dismissed their stale review via d264293 June 10, 2023 23:48

Lukas Alt and others added 9 commits June 10, 2023 18:48

prepare update for 1.20

0640661

update tests to 1.20 NMS

0592d27

Some fixes for 1.20

c47ff0c

fixed test cases lacking bukkit initialization

4fd8b25

Removed debug messages

d0474aa

Some fixes for 1.20

55a6ad6

Removed debug messages

c1981ce

several fixes

2c2d3dd

revert version

bc4ef51

dmulloy2 force-pushed the 1.20 branch from d264293 to bc4ef51 Compare June 10, 2023 23:50

rebase error

430a962

dmulloy2 approved these changes Jun 10, 2023

View reviewed changes

dmulloy2 enabled auto-merge (squash) June 10, 2023 23:53

dmulloy2 merged commit 1537c7e into dmulloy2:master Jun 10, 2023

Hanmingxuan mentioned this pull request Aug 30, 2023

ProtocolLib BlockhostOfficial/folia-plugins#48

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update to 1.20#2420

Update to 1.20#2420
dmulloy2 merged 10 commits intodmulloy2:masterfrom
lukalt:1.20

lukalt commented Jun 7, 2023 •

edited

Loading

Uh oh!

LOOHP commented Jun 7, 2023

Uh oh!

lukalt commented Jun 7, 2023

Uh oh!

LOOHP commented Jun 8, 2023

Uh oh!

lukalt commented Jun 8, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lukalt commented Jun 8, 2023

Uh oh!

Uh oh!

Uh oh!

metabrixkt commented Jun 10, 2023

Uh oh!

CrazyCraft88 commented Dec 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

lukalt commented Jun 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LOOHP commented Jun 7, 2023

Uh oh!

lukalt commented Jun 7, 2023

Uh oh!

LOOHP commented Jun 8, 2023

Uh oh!

lukalt commented Jun 8, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lukalt commented Jun 8, 2023

Uh oh!

Uh oh!

Uh oh!

metabrixkt commented Jun 10, 2023

Uh oh!

CrazyCraft88 commented Dec 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

lukalt commented Jun 7, 2023 •

edited

Loading