Skip to content

Cleanup II#1776

Closed
Photon-GitHub wants to merge 20 commits intodmulloy2:masterfrom
Photon-GitHub:Cleanup
Closed

Cleanup II#1776
Photon-GitHub wants to merge 20 commits intodmulloy2:masterfrom
Photon-GitHub:Cleanup

Conversation

@Photon-GitHub
Copy link
Copy Markdown
Contributor

Notable changes:

  • Lots of fields have been made final, especially in enums to prevent anyone from modifing them from another plugin (and therefore creating untracable bugs)
  • Many string concatenations in stringbuilder calls have been split into the correct append calls
  • In CommandFilter, an ArrayList masquerading as a map has been replaced with an actual map
  • Replaced another string equals chain with switch
  • Lots of unnecessary modifiers, especially in interfaces, have been removed
  • In AsyncListenerHandler a HashSet of Integer was replaced with an IntSet

@derklaro
Copy link
Copy Markdown
Contributor

Are you sure that FastUtil is available in Craftbukkit since 1.8?

@ghost
Copy link
Copy Markdown

ghost commented Jul 25, 2022

Are you sure that FastUtil is available in Craftbukkit since 1.8?

Is not

@Photon-GitHub Photon-GitHub deleted the Cleanup branch May 31, 2023 18:51
@Photon-GitHub Photon-GitHub mentioned this pull request May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants