Skip to content

Packets are being dropped on a large scale #1551

@bergerkiller

Description

@bergerkiller

Describe the bug
You are probably (hopefully!) already aware of this, but since the 5.0 version builds of protocollib everything has been broken on my end. Packets sent using both protocollib's sendServerPacket and using NMS protocol sendPacket method are being dropped, resulting in a whole host of problems:

  • Spawn packets arent being sent
  • Entity metadata packets arent being sent
  • Entity equipment packets arent being sent
  • Mount packets arent being sent

I've tried to see if it can have anything to do with my own code, so I cancelled packet listeners/monitors for packets but the problem remains.

To Reproduce
Steps to reproduce the behavior:

  1. Install BKCommonLib dev build https://ci.mg-dev.eu/job/BKCommonLib/1267/
  2. Install Traincarts https://ci.mg-dev.eu/job/TrainCarts/1086/
  3. Place a minecart
  4. Try entering it. Nothing happens because the mount packet TC sends isnt being sent.

For a more extreme demo, also install TC-Coasters ( https://ci.mg-dev.eu/job/TC%20Coasters/247/ ) and try to place down multiple nodes. Entity metadata is stripped so youve got a bunch of floating bats handing around.

Expected behavior
Packets not being dropped

Screenshots
ScreenShot_2022-03-26 14-32-44
ScreenShot_2022-03-26 14-34-04

Version Info
https://paste.traincarts.net/nunoderiji.pl

Additional context
This is the protocollib handler logic of BKCL. If this matters (maybe Im using a legacy API that 5.0 broke and I need to use a different API, for example) let me know what I should do differently.

https://github.com/bergerhealer/BKCommonLib/blob/master/src/main/java/com/bergerkiller/bukkit/common/internal/network/ProtocolLibPacketHandler.java

This problem did not exist with the 4.8 release on spigot, so Im currently telling people to use that one. A lot of people have been rolling with the 5.0 dev builds and its been a bit of a support pain over at the discord...

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions