Skip to content

feat: add trimWhitespace option#97

Merged
JoshuaKGoldberg merged 5 commits intodmnd:mainfrom
43081j:trim-ws
May 1, 2025
Merged

feat: add trimWhitespace option#97
JoshuaKGoldberg merged 5 commits intodmnd:mainfrom
43081j:trim-ws

Conversation

@43081j
Copy link
Copy Markdown
Contributor

@43081j 43081j commented Apr 25, 2025

Adds a trimWhitespace option which decides if we trim the leading and trailing whitespace of the result.

Draft until the issue is accepting PRs

PR Checklist

Adds a `trimWhitespace` option which decides if we trim the leading and
trailing whitespace of the result.
Copy link
Copy Markdown
Collaborator

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Copy Markdown
Collaborator

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or actually, could you please add a note to the README.md? escapeSpecialCharacters is mentioned there so trimWhitespace should be too.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review May 1, 2025 11:06
43081j and others added 2 commits May 1, 2025 13:00
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
@43081j
Copy link
Copy Markdown
Contributor Author

43081j commented May 1, 2025

should all be good now 👍

@JoshuaKGoldberg JoshuaKGoldberg self-requested a review May 1, 2025 12:33
Copy link
Copy Markdown
Collaborator

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 86902f7 into dmnd:main May 1, 2025
12 checks passed
@github-actions
Copy link
Copy Markdown

github-actions bot commented May 1, 2025

🎉 This is included in version v1.6.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🚀 Feature: add a trimWhitespace option

2 participants