feat: add alignValues option#102
Merged
JoshuaKGoldberg merged 4 commits intodmnd:mainfrom Sep 3, 2025
Merged
Conversation
JoshuaKGoldberg
requested changes
Aug 21, 2025
Collaborator
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
The logic all looks great, thanks for the quick PR! 🔥
I'd like to only block on one point: adding docs to the README.md. The other two I don't think should block merging the PR at all.
|
Any update? |
JoshuaKGoldberg
approved these changes
Sep 3, 2025
Collaborator
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
Looking great, thanks a bunch! ✨
|
🎉 This is included in version v1.7.0 🎉 The release is available on: Cheers! 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
This PR implements the
alignValuesoption fordedent()to handle interpolated values with proper indentation alignment. When enabled viadedent({ alignValues: true }), the function will align each interpolated value's indentation to match its starting line's indentation within the template literal.And added a basic test for nested interpolated string.