Add pointer to Microsoft.ML.Tokenizers#37
Merged
dmitry-brazhenko merged 1 commit intodmitry-brazhenko:mainfrom Apr 8, 2024
Merged
Add pointer to Microsoft.ML.Tokenizers#37dmitry-brazhenko merged 1 commit intodmitry-brazhenko:mainfrom
dmitry-brazhenko merged 1 commit intodmitry-brazhenko:mainfrom
Conversation
tarekgh
reviewed
Apr 5, 2024
| and .NET Standard 2.0, making it compatible with a wide range of frameworks. | ||
|
|
||
| > [!Important] | ||
| > The functionality in `SharpToken` has been added to [`Microsoft.ML.Tokenizers`](https://www.nuget.org/packages/Microsoft.ML.Tokenizers). `Microsoft.ML.Tokenizers` is a tokenizer library being developed by the .NET team and going forward, the central place for tokenizer development in .NET. By using `Microsoft.ML.Tokenizers`, you should see improved performance over existing tokenizer library implementations, including `SharpToken`. A stable release of `Microsoft.ML.Tokenizers` is expected alongside the .NET 9.0 release (November 2024). Instructions for migration can be found at https://github.com/dotnet/machinelearning/blob/main/docs/code/microsoft-ml-tokenizers-migration-guide.md. |
There was a problem hiding this comment.
should we specify the Tiktoken tokenizer to ensure users will not get lost which tokenizer to use when replacing SharpToken? I see the benchmark code has it but maybe not that obvious to the users? Tokenizer.CreateTiktokenForModel("gpt-4");
Contributor
Author
There was a problem hiding this comment.
Sure, I just copied this from the text that @luisquintanilla helped draft for DeepDev. We can mention Tiktoken.
edit: I see you meant more about migration. I think that should be added to the migration guide. Do you think you can do that @tarekgh?
tarekgh
approved these changes
Apr 5, 2024
dmitry-brazhenko
approved these changes
Apr 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add benchmark info for Microsoft.ML.Tokenizers and direct folks to this package.
cc @dmitry-brazhenko @tarekgh @luisquintanilla