fix: prevent panic when preview.open is false#799
Merged
dlvhdr merged 1 commit intodlvhdr:mainfrom Mar 7, 2026
Merged
Conversation
Bug: dash panics with “strings: negative Repeat count” when the config has preview.open set to false. Cause: When preview.open is false, DynamicPreviewWidth is 0 and GetSidebarContentWidth() returns a negative value (0 − BorderWidth). If syncSidebar() proceeds to render, this negative width propagates to strings.Repeat(), which panics on a negative count. Fix: Clamp GetSidebarContentWidth() with max(0, ...) so callers never see a negative width (root cause), and add an early return in syncSidebar() when the sidebar is closed so it doesn’t needlessly render with zero width (defense-in-depth). Fixes dlvhdr#798
dlvhdr
approved these changes
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: dash panics with "strings: negative Repeat count" when the config has
preview.openset tofalse.Cause: When
preview.openisfalse,DynamicPreviewWidthis 0 andGetSidebarContentWidth()returns a negative value (0 − BorderWidth). IfsyncSidebar()proceeds to render, that negative width propagates tostrings.Repeat(), which panics on a negative count.Fix: Clamp
GetSidebarContentWidth()withmax(0, ...)so callers never see a negative width (root cause), and add an early return insyncSidebar()when the sidebar is closed so it doesn't needlessly render with zero width (defense-in-depth). Fixes #798.