fix(notifications): fix confirmation prompt, refetch after mark-all-done, and show read notifications by default#785
Merged
dlvhdr merged 3 commits intodlvhdr:mainfrom Feb 27, 2026
Conversation
GetPromptConfirmation() had switch cases for PR, issue, and repo actions but was missing a case for “done_all” in NotificationsView. The prompt string stayed empty, rendering a blank confirmation box (though Enter still worked, because the handler did have the case).
After confirming “mark all as done”, the handler cleared the UI list but never triggered a refetch; you had to manually press “r”. Now the ClearAllNotificationsMsg handler resets pagination state and calls FetchNextPageSectionRows() to reload fresh data.
Add includeReadNotifications config option (default: true) so the default notification view shows all notifications instead of only unread ones, matching GitHub's default behavior. You can still filter explicitly with is:unread. To restore the old behavior, set “includeReadNotifications: false” in your config.
af57644 to
85ab51f
Compare
dlvhdr
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two Notifications dashboard bugs:
Blank “mark all as done” confirmation prompt –
GetPromptConfirmation()had cases for PR/issue/repo actions but was missingdone_allfor the Notifications dashboard. The confirmation box rendered blank (though Enter still worked, since the handler had the case).No refetch after “mark all as done” – After confirming, the handler cleared the UI list but returned no command, so no refetch was triggered. You had to manually press r. Now resets pagination state and calls
FetchNextPageSectionRows()to reload fresh data.…and makes one feature change:
includeReadNotificationsconfig option (default:true), so the default view shows all notifications instead of only unread, matching GitHub’s behavior. Explicitis:unread/is:readfilters still override this. SetincludeReadNotifications: falseto restore the old behavior.