fix: use Repository.HtmlUrl for notification URLs instead of hardcoding github.com#781
Merged
dlvhdr merged 1 commit intodlvhdr:mainfrom Feb 18, 2026
Merged
Conversation
…ng github.com Notification "open in browser" was hardcoded to https://github.com, which opens the wrong host on GitHub Enterprise instances. The GitHub notifications API already returns Repository.HtmlUrl with the correct host, so use that as the base URL instead. Falls back to https://github.com/<FullName> if HtmlUrl is empty. Fixes dlvhdr#778
dlvhdr
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repository.HtmlUrlfrom the GitHub API as the base for notification URLs instead of hardcodinghttps://github.com, fixing “open in browser” on GitHub Enterprise instanceshttps://github.com/<FullName>ifHtmlUrlis empty (defensive, shouldn't happen in practice)NotificationData.GetUrl()Fixes #778