fix: Enter key stops working after viewing a notification#764
Merged
dlvhdr merged 1 commit intodlvhdr:mainfrom Feb 7, 2026
Merged
fix: Enter key stops working after viewing a notification#764dlvhdr merged 1 commit intodlvhdr:mainfrom
dlvhdr merged 1 commit intodlvhdr:mainfrom
Conversation
When a notification is marked as done and removed from the list, the cached subject (subjectPR/subjectIssue) wasn't being cleared. This caused key dispatch to route keys to the wrong handler since it checks `GetSubjectPR() != nil` to determine which handler to use. Fix by clearing the cached subject in syncSidebar() when the current notification doesn't match the cached subject ID.
dlvhdr
approved these changes
Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where pressing Enter on a notification would stop working after viewing any notification. The first Enter would work, but subsequent presses (on the same or different notifications) would have no effect.
Problem
The NotificationsView key handler used a switch statement where the PR/Issue subject checks came before the Enter key check:
Once a notification was viewed and the subject set, Enter would be absorbed by the PR/Issue handler instead of triggering
loadNotificationContent().Solution
Move the Enter key handling before the subject checks:
Also clears the cached subject in
syncSidebar()when navigating to a different notification, ensuring key dispatch routes correctly.