feat(config): Ensure that tests run locally skip any local user config#747
Merged
dlvhdr merged 1 commit intodlvhdr:mainfrom Jan 28, 2026
Merged
Conversation
- Add a SkipGlobalConfig field to config.Location. That causes ParseConfig to load only a provided config file — without merging it with any local ~/.config/gh-dash/config.yml user-config file. - Update all existing test files to use SkipGlobalConfig: true. Those changes are useful for local testing, where user-defined keybindings in a user’s config can “intercept” built-in keys — causing tests to pass locally but fail in CI, where no such local user config exists.
6da744c to
c85d9b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a
SkipGlobalConfigfield to config.Location. That causesParseConfigto load only a provided config file — without merging it with any local~/.config/gh-dash/config.ymluser-config file.Update all existing test files to use
SkipGlobalConfig: true.Those changes are useful for local testing, where user-defined keybindings in a user’s config can “intercept” built-in keys — causing tests to pass locally but fail in CI, where no such local user config exists.
How did you test this change?
Ran the test suite locally :)