fix: multiple crash-inducing bugs and resource leaks#732
Merged
dlvhdr merged 1 commit intodlvhdr:mainfrom Jan 6, 2026
Merged
Conversation
dlvhdr
reviewed
Jan 5, 2026
- BranchData.GetUpdatedAt(): add nil check for LastUpdatedAt pointer - BranchData.GetRepoNameWithOwner(): add empty check for Remotes slice - reposection/prssection/issuessection GetCurrRow(): validate GetCurrItem() index is within bounds before accessing slice - cmd/root.go: fix file handle leak by assigning opened file to loggerFile so it gets returned and closed by caller - watchChecks.go: use captured values instead of calling GetCurrRow() again inside goroutine (race condition) - prapi.go: reuse cachedClient instead of creating new GraphQL client on every FetchPullRequest call (resource waste + variable shadowing) - markdownRenderer.go: handle error from glamour.NewTermRenderer with fallback renderer instead of dereferencing nil pointer
dbd2934 to
395eddc
Compare
dlvhdr
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
index is within bounds before accessing slice
so it gets returned and closed by caller
inside goroutine (race condition)
every FetchPullRequest call (resource waste + variable shadowing)
fallback renderer instead of dereferencing nil pointer
How did you test this change?
Added internal/tui/components/branch/data_test.go