fix: crash when switching to RepoView before data is loaded#731
Merged
dlvhdr merged 1 commit intodlvhdr:mainfrom Jan 7, 2026
Merged
fix: crash when switching to RepoView before data is loaded#731dlvhdr merged 1 commit intodlvhdr:mainfrom
dlvhdr merged 1 commit intodlvhdr:mainfrom
Conversation
When m.repo hasn't been initialized yet, return an empty slice – rather than a slice containing nil. That prevents a nil-pointer dereference when calling GetId() on the section – which in turn prevents dash from crashing on you when you try to switch into the Branch/Repo view.
dlvhdr
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
m.repohasn't been initialized yet, return an empty slice – rather than a slice containing nil. That prevents a nil-pointer dereference when callingGetId()on the section – which in turn prevents dash from crashing on you when you try to switch into the Branch/Repo view.How did you test this change?
Added a
TestGetCurrentViewSections_RepoViewWithNilRepotest ininternal/tui/ui_test.go