fix: preserve label colors when updating issue labels#727
Merged
dlvhdr merged 1 commit intodlvhdr:mainfrom Jan 2, 2026
Merged
Conversation
When editing labels on an issue, the label colors were lost because the returned labels only included the name but not the color. This fix creates a map of existing label colors and uses it when constructing the returned labels to preserve colors for labels that already existed on the issue. Fixes dlvhdr#721 Signed-off-by: majiayu000 <1835304752@qq.com>
dlvhdr
approved these changes
Jan 2, 2026
Owner
dlvhdr
left a comment
There was a problem hiding this comment.
Thanks that's great! What we really need to do is fetch the labels again though since the new labels won't have color :(
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #721
Changes