fix: crash when pressing “w” to watch checks#725
Merged
dlvhdr merged 1 commit intodlvhdr:mainfrom Jan 1, 2026
Merged
Conversation
This change fixes a case where the watchChecks function was creating an
empty prrow.Data{} struct, and calling GetStatusChecksRollup() on it – which
led to a nil-pointer dereference when accessing pr.Data.Primary.Commits.Nodes.
The change fixes that by not using an empty prrow.Data{} struct — and instead,
switching to using the actual PR data from the current row. It also adds a nil
check to GetStatusChecksRollup(), for further safety.
Fixes dlvhdr#718
Contributor
Author
Continued thanks for creating & maintaining (and ongoing refining) of such a great app, that’s a genuine delight to hack on~ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change fixes a case where the
watchChecksfunction was creating an emptyprrow.Data{}struct, and callingGetStatusChecksRollup()on it – which led to a nil-pointer dereference when accessingpr.Data.Primary.Commits.Nodes.The change fixes that by not doing the empty-
prrow.Data{}-struct thing — and instead, switching to using the actual PR data from the current row. It also adds a nil check toGetStatusChecksRollup(), for further safety.Fixes #718
How did you test this change?
Added unit tests for
GetStatusChecksRollup().