Conversation
dlvhdr
left a comment
There was a problem hiding this comment.
Hey! So this is pretty awesome and definitely super useful. Thanks for working on it.
I think in terms of usability it's very nice. I think the code needs some cleanup, mainly for readability, nothing major.
I've also left some design comments etc.
Otherwise, great work!
dlvhdr
left a comment
There was a problem hiding this comment.
Looks and behaves really great! Thx for putting so much effort into it!
| @@ -110,3 +208,14 @@ func (m *Model) UpdateProgramContext(ctx *context.ProgramContext) { | |||
| m.ctx = ctx | |||
| m.inputHelp.Styles = ctx.Styles.Help.BubbleStyles | |||
There was a problem hiding this comment.
I think you also need to update the styles for the autocomplete here? not sure why, but the help text isn't using the faint style
There was a problem hiding this comment.
Great catch! I added it to issueview.go since that is where m.ac is. I originally did a check for m.ac != nil before updating the context, but I think since it is in issueview.go, m.ac will always be defined. Am I thinking about that right?
dlvhdr
left a comment
There was a problem hiding this comment.
Looks and behaves really great! Thx for putting so much effort into it!
a28d7eb to
5a4ff71
Compare
Use runes to extract and replace labels to avoid problems with multi-byte characters
Replaced "Labels" with "Suggestions" in `FetchLabelsRequestedMsg` and `FetchLabelsKey` to make them both more generic.
- Send ClearFetchStatusMsg after 2s to reset success/error states - Make SetFetchSuccess and SetFetchError return a tea.Cmd so callers (issueview) can schedule the clear - Forward messages to autocomplete - Update so spinner/status remain synchronized
5a4ff71 to
17ff5cb
Compare
|
Looks great @mchisolm0! I'm good with merging this. We can do another pass once bubbletea v2 is released and convert it to a cleaner popup. |
Summary
Add a suggestion/completion system for labels. Built on top of #719 to close #716.
How did you test this change?
I built the extension locally and started it in the terminal. I opened an issue, began typing a label,
ctrl + nandctrl + pfor next/previous, and clicked enter or tab to accept.Images/Videos
CleanShot.2025-12-27.at.03.02.15.mp4