Minor tweaks and cleanup#822
Merged
xzyfer merged 4 commits intodlmanning:masterfrom Oct 12, 2021
XhmikosR:patch-1
Merged
Conversation
XhmikosR
commented
Oct 6, 2021
XhmikosR
commented
Oct 6, 2021
XhmikosR
commented
Oct 6, 2021
Contributor
Author
|
I'm going to move the other changes to separate PRs so that's easier to review :) |
Collaborator
|
Migrating to GitHub actions was a great value add, but I don't think
there's value in materially changing the plugin itself. It's been largely
unchanged for a couple years now and is prefer to keep it that way from a
maintenance perspective.
…On Thu, 7 Oct 2021, 3:01 pm XhmikosR, ***@***.***> wrote:
I'm going to move the other changes to separate PRs so that's easier to
review :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#822 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAENSWBUN27HS2T4G64DOZTUFULQ3ANCNFSM5FOFWFEA>
.
|
Contributor
Author
|
I see your point, totally, but all I'm trying to do is to only make the code simpler for the future. And since I've already done most of the changes, it'd be a pity to not land them :) |
* enable strict mode (these aren't modules) * use a template literal for the missing compiler message * move variables where we use them * disable a few ESLint rules * move ESLint overrides around
xzyfer
approved these changes
Oct 8, 2021
Collaborator
xzyfer
left a comment
There was a problem hiding this comment.
Thanks for you all your work! I'll merge this when I'm able to cut a release.
Contributor
Author
Collaborator
|
Sure. I'll take a closer look when they're in a PR before merging. |
Contributor
Author
|
They depend on this PR, should I push them here as separate patches and you squash when merging? |
Collaborator
|
Yeah just land the commits here. I've already read this PR so I can audit
those individual commits as part of this PR.
…On Fri, 8 Oct 2021, 11:11 pm XhmikosR, ***@***.***> wrote:
They depend on this PR, should I push them here as separate patches and
you squash when merging?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#822 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAENSWGXDNVHY4KFYYZQO5TUF3NXDANCNFSM5FOFWFEA>
.
|
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non-whitespace diff is cleaner: https://github.com/dlmanning/gulp-sass/pull/822/files?w=1