This repository was archived by the owner on Jan 27, 2022. It is now read-only.
Bas Westerbaan's suggested speed improvement for random.shuffle.#83
Closed
mitchellrj wants to merge 1 commit into
Closed
Bas Westerbaan's suggested speed improvement for random.shuffle.#83mitchellrj wants to merge 1 commit into
mitchellrj wants to merge 1 commit into
Conversation
Member
|
Rejecting this for now. See my comment on the commit. The suggested routine performs well on small inputs, but completely falls apart on the computation of math.factorial(len(x)) with even a moderate-sized list (e.g. a million entries). I worry that if I merged this, it would introduce a DoS vulnerability. randrange() should just be faster. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://bugs.launchpad.net/pycrypto/+bug/1171237