Skip to content

Optimize isHexDigit#8597

Merged
thewilsonator merged 1 commit intodlang:masterfrom
deadalnix:isHexDigit
Oct 13, 2022
Merged

Optimize isHexDigit#8597
thewilsonator merged 1 commit intodlang:masterfrom
deadalnix:isHexDigit

Conversation

@deadalnix
Copy link
Contributor

Before:

        lea     eax, [rdi - 48]
        cmp     eax, 54
        ja      .LBB0_1
        lea     ecx, [rdi - 97]
        mov     al, 1
        cmp     ecx, -39
        jb      .LBB0_4
        add     edi, -65
        cmp     edi, 6
        setb    al
.LBB0_4:
        ret
.LBB0_1:
        xor     eax, eax
        ret

After:

        lea     eax, [rdi - 48]
        cmp     eax, 10
        setb    cl
        or      edi, 32
        add     edi, -97
        cmp     edi, 6
        setb    al
        or      al, cl
        ret

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @deadalnix! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8597"

@thewilsonator thewilsonator merged commit 60b78df into dlang:master Oct 13, 2022
@deadalnix deadalnix deleted the isHexDigit branch October 13, 2022 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants