Skip to content

Add spacing to VStack in InternalWrappingHStack#13

Closed
SongJiyeon wants to merge 2 commits into
dkk:mainfrom
SongJiyeon:main
Closed

Add spacing to VStack in InternalWrappingHStack#13
SongJiyeon wants to merge 2 commits into
dkk:mainfrom
SongJiyeon:main

Conversation

@SongJiyeon

Copy link
Copy Markdown

Not to handle neighbor components because of padding of items, I added spacing to VStack in InternalWrappingHStack.

  • Add verticalSpacing input to Spacing enum of WrappingHStack.
  • Because of default value of verticalSpacing, this is not a breaking change for existing users. You can see there is no problem with example view who doesn't have verticalSpacing like before.

@dkk

dkk commented Dec 2, 2021

Copy link
Copy Markdown
Owner

Hi @SongJiyeon,

sorry for the late response, I have been quite busy. Thanks a lot for your work. Unfortunatelly, your code does not handle dynamic spacings correctly.

In addition, I think that constant vertical spaces should be provided by the item definition, i.e. by giving them a padding. This way you would have the right separation for each item instead of line by line.

Dynamic vertical spacings could be needed sometimes and can't be defined by the items, but I don't think there is really a need for it. Maybe if someone creates a feature request I'll think of implementing it...

@dkk dkk closed this Dec 2, 2021
@dkk dkk mentioned this pull request Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants