Add spacing to VStack in InternalWrappingHStack#13
Closed
SongJiyeon wants to merge 2 commits into
Closed
Conversation
Owner
|
Hi @SongJiyeon, sorry for the late response, I have been quite busy. Thanks a lot for your work. Unfortunatelly, your code does not handle dynamic spacings correctly. In addition, I think that constant vertical spaces should be provided by the item definition, i.e. by giving them a padding. This way you would have the right separation for each item instead of line by line. Dynamic vertical spacings could be needed sometimes and can't be defined by the items, but I don't think there is really a need for it. Maybe if someone creates a feature request I'll think of implementing it... |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not to handle neighbor components because of padding of items, I added spacing to VStack in InternalWrappingHStack.
verticalSpacinginput toSpacingenum of WrappingHStack.