Do not export unnecessary symbols + port to dune + Windows fixes#42
Merged
djs55 merged 4 commits intodjs55:masterfrom Feb 7, 2020
nojb:master
Merged
Do not export unnecessary symbols + port to dune + Windows fixes#42djs55 merged 4 commits intodjs55:masterfrom nojb:master
djs55 merged 4 commits intodjs55:masterfrom
nojb:master
Conversation
Signed-off-by: Nicolás Ojeda Bär <n.oje.bar@gmail.com>
Signed-off-by: Nicolás Ojeda Bär <n.oje.bar@gmail.com>
Signed-off-by: Nicolás Ojeda Bär <n.oje.bar@gmail.com>
|
With dune 2.0 integration sha blocks dune upgrade by depending on jbuilder.transition. So merging this PR is very important. |
|
Could you please fix the opam file too? @djs55 ping? |
Contributor
Author
Fixed, thanks. |
|
Still missing the description or synopsis though. |
|
Can this be prioritized? The latest version of dune gives error for jbuilder projects.
|
Owner
|
Thanks and sorry for the delay. I'll merge this and see what else needs to be done before a release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
I made a number of small fixes to
ocaml-shawhich you may be interested in integrating:it turns out that some of the symbols in
sha{1,256,512}c.cclash with symbols exported bycamlpdf, which makes it impossible to link both together. To work around this issue I inlinesha{1,256,512}c.cinside the headersha{1,256,512}.hand declare all functions to be static. The files are small enough that this is not too messy.Port to dune from jbuilder
Some Windows fixes which allow to compile on Windows out-of-the-box.
Thanks!