Skip to content
This repository was archived by the owner on Jan 26, 2024. It is now read-only.

Set XCURSOR_SIZE to fix cursor changing size#425

Merged
sevz17 merged 1 commit intodjpohly:mainfrom
NikitaIvanovV:set-xcursor-size
Jun 2, 2023
Merged

Set XCURSOR_SIZE to fix cursor changing size#425
sevz17 merged 1 commit intodjpohly:mainfrom
NikitaIvanovV:set-xcursor-size

Conversation

@NikitaIvanovV
Copy link
Copy Markdown
Contributor

When I hover a cursor over various clients, the cursor changes its size. For example, it's normal size on foot and becomes bigger in qutebrowser. I figured out that these clients use XCURSOR_SIZE env variable to determine appropriate cursor size and when it's unset, they fallback to using some default value. I presume this default is not the same on all clients, this is why cursor size changes. This PR adds a setenv call to make sure XCURSOR_SIZE is set to the proper value.

@bencollerson
Copy link
Copy Markdown
Contributor

This is a good tip and is working for me by setting XCURSOR_SIZE in my dwl start up script.

Not sure about this particular implementation though as there may be users already setting this variable in their environment outside of dwl. This patch would just overwrite any existing environment setting with no way to use an externally set value.

@sevz17
Copy link
Copy Markdown
Collaborator

sevz17 commented Jun 2, 2023

This is a good tip and is working for me by setting XCURSOR_SIZE in my dwl start up script.

Not sure about this particular implementation though as there may be users already setting this variable in their environment outside of dwl. This patch would just overwrite any existing environment setting with no way to use an externally set value.

Actually setting XCURSOR_{THEME,SIZE} it the compositor's job, the reason dwl doesn't set it is because it doesn't let the user to customize the cursor

@sevz17 sevz17 merged commit f8884ff into djpohly:main Jun 2, 2023
@sevz17
Copy link
Copy Markdown
Collaborator

sevz17 commented Jun 2, 2023

Thanks!

@bencollerson
Copy link
Copy Markdown
Contributor

Haha I stand corrected. ;)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants