This repository was archived by the owner on Jan 26, 2024. It is now read-only.
Prevent using a wlr_layer_surface after destroying it#421
Merged
sevz17 merged 1 commit intodjpohly:mainfrom May 26, 2023
Merged
Prevent using a wlr_layer_surface after destroying it#421sevz17 merged 1 commit intodjpohly:mainfrom
sevz17 merged 1 commit intodjpohly:mainfrom
Conversation
Collaborator
|
Thanks! |
Author
|
Thank you!
…On Thu, May 25, 2023, at 9:22 PM, Leonardo Hernández wrote:
Thanks!
—
Reply to this email directly, view it on GitHub <#421 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADSRCHUPM6UMQ3QA7U7EE3XIAOWLANCNFSM6AAAAAAYNUDLYE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the
createlayersurfacecallback is hit whenselmonis NULL thenwlr_layer_surfaceis destroyed by callingwlr_layer_surface_v1_destroy(). This change simply adds a return at that point, to prevent a crash caused by dereferencing the destroyed variable.The crash in question can be reproduced easily by unplugging or turning off all monitors while running
swaync, waiting a few seconds and then plugging them back in. It is likely possible to cause this with things other thanswaync, but that was the application that triggered it for me.