Make rustls connector more flexible #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@djc I've to admit, that my proposal really was quick and dirty. I'll have a look into your solution and adopt it, if possible :-) Regarding the use case: We are operating multiple EPP servers and I am eager to improve the monitoring by substituting some of our current checks by a more versatile solution. Thus I only need the check and hello commands and various methods to connect to endpoints. Since the registry system does not use rust, I had to look for an alternative library and stumbled about epp-client and instant-epp... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Morpheus9 this is my proposed alternative to #58. I think that code is a bit messy, and I don't think this project should carry around unsafe verifier implementations. Using the API proposed in this PR, it should be possible to plug in alternative verifiers in your downstream project.
Curious to hear your use case -- would be cool if your organization could sponsor continued maintenance of instant-epp.