build(deps): upgrade hashbrown to v0.16#38
Closed
paolobarbolini wants to merge 1 commit intodjc:mainfrom
paolobarbolini:hashbrown-0.16
Closed
build(deps): upgrade hashbrown to v0.16#38paolobarbolini wants to merge 1 commit intodjc:mainfrom paolobarbolini:hashbrown-0.16
paolobarbolini wants to merge 1 commit intodjc:mainfrom
paolobarbolini:hashbrown-0.16
Conversation
|
|
||
| [dependencies] | ||
| hashbrown = { version = "0.15", default-features = false, features = ["default-hasher", "inline-more"] } | ||
| hashbrown = { version = "0.16", default-features = false, features = ["default-hasher", "inline-more"] } |
Contributor
There was a problem hiding this comment.
If we could make this a range dependency instead of a hard upgrade, that would make my life for upgrading hashbrown incrementally in Firefox a lot easier! 😖🙏🏻
Contributor
There was a problem hiding this comment.
For convenience, that would make this line:
Suggested change
| hashbrown = { version = "0.16", default-features = false, features = ["default-hasher", "inline-more"] } | |
| hashbrown = { version = ">=0.15,<=0.16", default-features = false, features = ["default-hasher", "inline-more"] } |
Owner
|
I've taken care of the simple version of this in #41 (to expedite things). @ErichDonGubler open to a PR that turns it into a range, although it would either be best effort or you should add CI flows to make sure both versions are tested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.