Skip to content

redis: Support redis v1.0.0-rc#263

Merged
djc merged 1 commit into
djc:mainfrom
jayvdb:redis-1.0
Oct 14, 2025
Merged

redis: Support redis v1.0.0-rc#263
djc merged 1 commit into
djc:mainfrom
jayvdb:redis-1.0

Conversation

@jayvdb

@jayvdb jayvdb commented Oct 12, 2025

Copy link
Copy Markdown
Contributor

@jayvdb jayvdb mentioned this pull request Oct 12, 2025
Open
@codecov

codecov Bot commented Oct 12, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.88%. Comparing base (7d13fe2) to head (8234268).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
redis/src/lib.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #263   +/-   ##
=======================================
  Coverage   80.88%   80.88%           
=======================================
  Files           6        6           
  Lines         633      633           
=======================================
  Hits          512      512           
  Misses        121      121

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@djc

djc commented Oct 12, 2025

Copy link
Copy Markdown
Owner

I don't think a Cargo feature makes sense for this, but I'm open to publishing a bb8-redis rc release that depends on the redis 1 rc.

@jayvdb

jayvdb commented Oct 12, 2025

Copy link
Copy Markdown
Contributor Author

I'm open to publishing a bb8-redis rc release that depends on the redis 1 rc.

Thanks. The code change here is trivial, so im happy for you to go ahead and create an -rc release using a different approach.

@djc

djc commented Oct 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Owner

Can you make the following changes to the PR:

  • Bump the bb8-redis version to 0.25.0-rc.1
  • Update the redis dependency to 1.0.0-rc.1 (no range)
  • Add whatever changes to make it compile

@jayvdb jayvdb changed the title redis: Add redis-1 feature to support redis v1.0.0-rc redis: Support redis v1.0.0-rc Oct 14, 2025
@djc djc merged commit b34c071 into djc:main Oct 14, 2025
9 of 10 checks passed
@djc

djc commented Oct 14, 2025

Copy link
Copy Markdown
Owner

Published.

@jayvdb jayvdb deleted the redis-1.0 branch October 14, 2025 18:28
jayvdb
jayvdb commented Oct 28, 2025
View reviewed changes
Comment thread redis/Cargo.toml
[dependencies]
bb8 = { version = "0.9", path = "../bb8" }
redis = { version = "0.32", default-features = false, features = ["tokio-comp"] }
redis = { version = "1.0.0-rc.1", default-features = false, features = ["tokio-comp"] }

@jayvdb jayvdb Oct 28, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi they are up to https://crates.io/crates/redis/1.0.0-rc.2 now

@djc djc Oct 28, 2025

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't pinned. Might just work? Otherwise, feel free to send a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@djc djc djc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jayvdb @djc