Skip to content

Remove extra form-selects in a results file#99

Closed
jmoppel wants to merge 0 commit into
django-crispy-forms:mainfrom
jmoppel:main
Closed

Remove extra form-selects in a results file#99
jmoppel wants to merge 0 commit into
django-crispy-forms:mainfrom
jmoppel:main

Conversation

@jmoppel

@jmoppel jmoppel commented Mar 7, 2022

Copy link
Copy Markdown
Contributor

Fixes 2 mistakes in the test_prepended_appended_select.html result file.
Remove extraneous form-select values in two class attributes in the
results file.
Causes the previous failing test_select_prepend to pass.

@jmoppel

jmoppel commented Mar 7, 2022

Copy link
Copy Markdown
Contributor Author

Thanks for kicking off CI! The Python 3.6 series received its last security update about six months ago and is no longer supported. Does it make sense to just run CI against Python 3.7+, especially since Python 3.6 and older are causing problems? It looks like 3.6 would still work, but would just have a couple of repeated class values.

@smithdc1

smithdc1 commented Mar 7, 2022

Copy link
Copy Markdown
Member

Yes we should drop 3.6 and add 3.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants