Add support for accordion-flush and accordion always open#63
Merged
Conversation
Contributor
Author
Contributor
Author
|
Well, tests passed. Let me know what you think of the new tests and the way I used the classes at bootstrap5.py. Those are the points I'm most unsure about. Cheers! |
smithdc1
reviewed
Jun 12, 2021
smithdc1
left a comment
Member
There was a problem hiding this comment.
This looks good, thank you. 👍
Although I've not yet sat down with this properly I've left a few initial comments.
Thanks again. :-)
smithdc1
reviewed
Jun 14, 2021
smithdc1
reviewed
Jun 15, 2021
smithdc1
reviewed
Jun 17, 2021
smithdc1
left a comment
Member
There was a problem hiding this comment.
Thanks for the updates. Would you like to add a small note to the readme to document the new feature in this template pack? Happy to help, just let me know.
Contributor
Author
Of course! I'll follow the floating labels note style |
Member
|
Thanks for all your efforts here 🥇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #60, #61 and #62. Tests should work now.
The term "always open" sounds misleading to me, but it's what the folks at Bootstrap use. We could change this to something more descriptive if judged necessary.
I'm not sure about the way I pulled classes from bootstrap.py. It feels awkward. I was inheriting from the original classes before and adding just what I needed, but it somehow felt worse. Any suggestions?