Update field_with_buttons.html#44
Conversation
Add missing form-label class
|
Thanks. Could you add a test? See #36 for how were currently building tests. |
|
@smithdc1 is it ok for you ? |
|
Thanks for your continued efforts here. 👍 Could we amend the test to test the whole form? It should be "just" a case of putting the crispy-bootstrap5/tests/test_layout.py Line 564 in 78981e7 Most of the tests here come from bootstrap4 which were written with partial coverage in code which has been an issue for a long time. We're slowly trying to move to this new method which I'm hoping is more maintainable. |
|
Hi @digitalfox -- I finally got time to sit down with this properly. I think this layout object is one I've not looked at in detail yet. I've pushed a few amends to make it work with bootstap5 button-addons (see link below). There is also a need to fix the input size for this object but that's a patch for crispy-forms core. Let me know what you think? https://getbootstrap.com/docs/5.0/forms/input-group/#button-addons |
|
Thanks for the merge. Sorry, I did not have time to have a look. I hope to be able to test it next month. |
Add missing form-label class