Skip to content
/ django Public

Fixed #22383 -- Added support for HTML5 required attribute on required form fields.#6352

Closed
jdufresne wants to merge 1 commit intodjango:masterfrom
jdufresne:html5-required-no-warning
Closed

Fixed #22383 -- Added support for HTML5 required attribute on required form fields.#6352
jdufresne wants to merge 1 commit intodjango:masterfrom
jdufresne:html5-required-no-warning

Conversation

@jdufresne
Copy link
Member

https://code.djangoproject.com/ticket/22383

Same as PR #6341 but without the deprecation cycle.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should explain how this works for formsets somewhere. Maybe here and elsewhere?

@timgraham
Copy link
Member

Please check the docs for rendered form examples that might need to be updated, e.g. docs/topics/forms/index.txt.

@jdufresne
Copy link
Member Author

I have addressed the concern. All additional feedback is welcome. Thanks.

Should explain how this works for formsets somewhere. Maybe here and elsewhere?

Added some text to ref/forms/api.txt and to topics/forms/formsets.txt. Please let me know what you think and if this addresses what you had in mind.

Please check the docs for rendered form examples that might need to be updated, e.g. docs/topics/forms/index.txt.

Done. This resulted in changes to:

  • refs/forms/api.txt
  • refs/forms/fields.txt
  • refs/forms/widgets.txt
  • topics/forms/index.txt

@timgraham
Copy link
Member

merged in ec61216, thanks!

@timgraham timgraham closed this Apr 21, 2016
@jdufresne jdufresne deleted the html5-required-no-warning branch May 11, 2016 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants