Fixed #25761 -- Re-raised exceptions need __cause__.__traceback__#5721
Closed
rhertzog wants to merge 1 commit intodjango:masterfrom
Closed
Fixed #25761 -- Re-raised exceptions need __cause__.__traceback__#5721rhertzog wants to merge 1 commit intodjango:masterfrom
rhertzog wants to merge 1 commit intodjango:masterfrom
Conversation
When Django re-raises an exception, it sets the __cause__ attribute even in Python 2, thus mimicking Python's 3 behaviour for "raise Foo from Bar". However Python 3 also ensures that all exceptions have a __traceback__ attribute and thus the "traceback2" Python 2 module (backport of Python 3's "traceback" module) relies on the fact that whenever you have a __cause__ attribute, the recorded exception also has a __traceback__ attribute. This is breaking at least testtools which is using traceback2 (see testing-cabal/testtools#162). This commit fixes this inconsistency by ensuring that Django sets the __traceback__ attribute on any exception stored in a __cause__ attribute of a re-raised exception.
Member
|
merged in 9f4e031, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Django re-raises an exception, it sets the cause attribute even
in Python 2, thus mimicking Python's 3 behaviour for "raise Foo from Bar".
However Python 3 also ensures that all exceptions have a traceback
attribute and thus the "traceback2" Python 2 module (backport of Python
3's "traceback" module) relies on the fact that whenever you have a
cause attribute, the recorded exception also has a traceback
attribute.
This is breaking at least testtools which is using traceback2 (see
testing-cabal/testtools#162).
This commit fixes this inconsistency by ensuring that Django sets
the traceback attribute on any exception stored in a cause
attribute of a re-raised exception.