Address #16855 - Deprecate depth kwarg on select_related.#488
Closed
mjtamlyn wants to merge 1 commit intodjango:masterfrom
Closed
Address #16855 - Deprecate depth kwarg on select_related.#488mjtamlyn wants to merge 1 commit intodjango:masterfrom
mjtamlyn wants to merge 1 commit intodjango:masterfrom
Conversation
This is the start of a deprecation path for the depth kwarg on select_related. Removing this will allow us to update select_related so it chains properly and have a more similar API to prefetch_related.
Member
There was a problem hiding this comment.
This should be a PendingDeprecationWarning at this time. (Also a \n would help readability.)
Member
|
merged with some extra docs modifications in 965cc0b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the start of a deprecation path for the depth kwarg on select_related. Removing this will allow us to update select_related so it chains properly and have a more similar API to prefetch_related.