Limited lines to 119 characters in django/{contrib,db}.#3421
Closed
berkerpeksag wants to merge 1 commit intodjango:masterfrom
berkerpeksag:fix-e501
Closed
Limited lines to 119 characters in django/{contrib,db}.#3421berkerpeksag wants to merge 1 commit intodjango:masterfrom berkerpeksag:fix-e501
berkerpeksag wants to merge 1 commit intodjango:masterfrom
berkerpeksag:fix-e501
Conversation
Member
There was a problem hiding this comment.
I won't require it if you don't like it, but the style I prefer is
raise RuntimeError(
"Error..."
)
(allows longer lines of text and less need to break the string up)
Contributor
Author
|
Done. Thanks for the review. |
django/db/migrations/autodetector.py
Outdated
Member
There was a problem hiding this comment.
please check flake8, I believe this is a warning because the line identation isn't distinguished from the next (fix by add 4 more spaces to this line)
Contributor
Author
|
Done. Thanks! |
Member
There was a problem hiding this comment.
I like to include a trailing comma in cases like this, so if more items are added, we don't need to modify that line again. Will make this change and commit.
Member
|
merged in c9178ef, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #23395.
https://code.djangoproject.com/ticket/23395