Skip to content
/ django Public

made sure "localhost" is recognized as invalid URL#19096

Closed
ludwigkraatz wants to merge 1 commit intodjango:mainfrom
ludwigkraatz:patch-2
Closed

made sure "localhost" is recognized as invalid URL#19096
ludwigkraatz wants to merge 1 commit intodjango:mainfrom
ludwigkraatz:patch-2

Conversation

@ludwigkraatz
Copy link
Copy Markdown

@ludwigkraatz ludwigkraatz commented Jan 23, 2025

if its lacking a scheme like "https", localhost ist invalid.

Trac ticket number

ticket-36131

Branch description

Provide a concise overview of the issue or rationale behind the proposed changes.

Checklist

  • This PR targets the main branch.
  • The commit message is written in past tense, mentions the ticket number, and ends with a period.
  • I have checked the "Has patch" ticket flag in the Trac system.
  • I have added or updated relevant tests.
  • I have added or updated relevant docs, including release notes if applicable.
  • I have attached screenshots in both light and dark modes for any UI changes.

if its lacking a scheme like "https", localhost ist invalid.
@github-actions github-actions bot added the no ticket Based on PR title, no linked Trac ticket label Jan 23, 2025
@ludwigkraatz ludwigkraatz deleted the patch-2 branch January 24, 2025 14:01
@ludwigkraatz
Copy link
Copy Markdown
Author

my bad - this was testing URLField - not URLValidator. URLField uses lazy scheme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no ticket Based on PR title, no linked Trac ticket

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant