-
-
Notifications
You must be signed in to change notification settings - Fork 33.5k
Removed unneeded sentence on contributing page. #18728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello! Thank you for your contribution 💪
As it's your first contribution be sure to check out the patch review checklist.
If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!
If you have any design or process questions then you can ask in the Django forum.
Welcome aboard ⛵️!
pauloxnet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Maria, I think it makes sense. Do you think we can add an alternate text to the images to improve accessibility?
a783a32 to
7d3879e
Compare
…ng docs. This is not needed as the console snippet has buttons that allows the user to choose their OS.
7d3879e to
99d08fc
Compare
sarahboyce
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @mariahynes - welcome onboard ⛵
I'm not very good at doing that myself! I added some alt text 👍 |
Great, more accessibility improvements 👍 |
Trac ticket number
N/A
Branch description
The users of the django documentation can choose to view certain commands in two different flavours. It is because of this, that the highlighted sentence is not needed on this page https://docs.djangoproject.com/en/dev/intro/contributing/:
This PR removes the highlighted line. Here is the revised section from my local doc build after making this change:
Checklist
mainbranch.