Fixed #35680 -- Added default automatic imports to shell.#18560
Fixed #35680 -- Added default automatic imports to shell.#18560sarahboyce merged 1 commit intodjango:mainfrom
Conversation
sarahboyce
left a comment
There was a problem hiding this comment.
Thank you for picking this up @salvo-polizzi
This is missing doc updates 👍
9e081b2 to
d64af28
Compare
Hi @sarahboyce, do you think it would be better to add this as a note in the shell section of |
Basically all docs that were updated in the previous commit refer to the models as the only thing auto imported. All of these references would need updating |
d93fb68 to
2bb6a07
Compare
475d54c to
5bdf927
Compare
sarahboyce
left a comment
There was a problem hiding this comment.
Thank you for updating the PR @salvo-polizzi ⭐
docs/howto/custom-shell.txt needs to be updated as it mentions that only models are what are imported by default, I feel we should be more general such as "plus what is imported by default as described by "
We are missing a release note in 6.0 👍
5bdf927 to
70eeb69
Compare
|
Hi @sarahboyce, Thank you for your review! 👍 I've made some updates to the documentation:
Please let me know if I missed anything or if there’s anything you'd like me to refine. |
sarahboyce
left a comment
There was a problem hiding this comment.
Thank you for the updates!
70eeb69 to
c88c9dc
Compare
docs/howto/custom-shell.txt
Outdated
There was a problem hiding this comment.
I would update assuming isort is installed
There was a problem hiding this comment.
Sure, my bad 👍
c88c9dc to
80dc864
Compare
|
@salvo-polizzi just so you are aware of my current thoughts, I am reluctant to merge anything until at least 2 months after the 5.2 final release. I would like us to receive some user feedback on the auto imports before we build on top of it |
Sure, let's keep this for later discussions when we have a greater consensus and feedback about this. |
sarahboyce
left a comment
There was a problem hiding this comment.
Note we did an update in de1117e which added tests.shell.tests.ShellCommandTestCase.test_no_settings, I think it's worth adding an assert to confirm that these are not imported to the namespace
a50278a to
c0b953e
Compare
Thank you @sarahboyce for pointing out this 👍 |
c0b953e to
01fbd32
Compare
|
Hi @sarahboyce, thank you for the review ⭐ (It's good to hear from you)! |
sarahboyce
left a comment
There was a problem hiding this comment.
Thank you! I have a few minor suggestions around the release/version changed notes and then I think this looks good to me 👍
31c16da to
68565ea
Compare
…nagement command.
sarahboyce
left a comment
There was a problem hiding this comment.
Thank you! This looks good to me
Trac ticket number
ticket-35680
Branch description
Builds on top of #18158 which must be merged first.
Added default automatic imports to shell following this discussion.
Checklist
mainbranch.