Fixed #35090 -- Deprecated registering URL converters with the same name.#17703
Fixed #35090 -- Deprecated registering URL converters with the same name.#17703felixxm merged 1 commit intodjango:mainfrom
Conversation
|
THank you for the work, though the ticket is not accepted yet. I think we should wait to see some input from others to accept it. One change that your PR will require is using the deprecation policy. We would need to warn at first, and then two versions later we can raise an exception. Read the policy and check out some recent PRs that have deprecated other features. |
c4a2688 to
e82c59b
Compare
e82c59b to
5357484
Compare
felixxm
left a comment
There was a problem hiding this comment.
@salvo-polizzi Thanks 👍 I left comments.
e7870c5 to
6b715af
Compare
adamchainz
left a comment
There was a problem hiding this comment.
Thanks for the continued work. I’ve left some comments on the tests.
6b715af to
82958df
Compare
|
Thanks @adamchainz for review |
82958df to
5600f8c
Compare
adamchainz
left a comment
There was a problem hiding this comment.
Minor formatting adjustment but otherwise LGTM!
5600f8c to
6e1ece7
Compare
felixxm
left a comment
There was a problem hiding this comment.
@salvo-polizzi Thanks 👍 I pushed final edits 👍
@adamchainz @shangxiao Thanks for reviews.
Ticket 35090