Fixed #16855 -- select_related() chains as expected.#1750
Closed
mjtamlyn wants to merge 1 commit intodjango:masterfrom
Closed
Fixed #16855 -- select_related() chains as expected.#1750mjtamlyn wants to merge 1 commit intodjango:masterfrom
mjtamlyn wants to merge 1 commit intodjango:masterfrom
Conversation
django/db/models/sql/query.py
Outdated
Member
There was a problem hiding this comment.
or isinstance(self.select_related, bool)?
Member
Author
There was a problem hiding this comment.
Seems both are used in the code base but yes the isinstance is likely better
select_related('foo').select_related('bar') is now equivalent to
select_related('foo', 'bar').
Also reworded docs to recommend select_related(*fields) over select_related()
Contributor
There was a problem hiding this comment.
"more complex queries that return larger data sets" - it's not immediately clear otherwise what is meant by a "larger query"
Member
Author
|
Fixed in 349c12d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
select_related('foo').select_related('bar') is now equivalent to
select_related('foo', 'bar').
Also reworded docs to recommend select_related(*fields) over select_related()
Ticket