Skip to content

Fixed #34054 -- Created a new fixtures topic.#16112

Merged
felixxm merged 1 commit intodjango:mainfrom
filiplajszczak:fixtures-topic
Nov 2, 2022
Merged

Fixed #34054 -- Created a new fixtures topic.#16112
felixxm merged 1 commit intodjango:mainfrom
filiplajszczak:fixtures-topic

Conversation

@filiplajszczak
Copy link
Copy Markdown
Contributor

@filiplajszczak filiplajszczak commented Sep 25, 2022

Up for discussion https://code.djangoproject.com/ticket/34054
Waiting for #16104 to to be decided upon.

@filiplajszczak filiplajszczak changed the title Fixed #34064. Adds Fixtures Topic. Fixed #34054. Adds Fixtures Topic. Sep 25, 2022
@filiplajszczak filiplajszczak force-pushed the fixtures-topic branch 2 times, most recently from e8bd46e to 02ca00f Compare September 26, 2022 19:35
@felixxm
Copy link
Copy Markdown
Member

felixxm commented Oct 13, 2022

@filiplajszczak Do you have time to keep working on this?

@filiplajszczak filiplajszczak marked this pull request as ready for review October 13, 2022 12:25
@filiplajszczak
Copy link
Copy Markdown
Contributor Author

I'm ok with the current state of is, but I would be happy to hear from @evildmp

Copy link
Copy Markdown
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@filiplajszczak Thanks 👍 I left small suggestions.

@filiplajszczak filiplajszczak force-pushed the fixtures-topic branch 3 times, most recently from 92ee518 to a825862 Compare November 1, 2022 09:19
@filiplajszczak
Copy link
Copy Markdown
Contributor Author

@felixxm applied suggestions, squashed & rebased.

Moved material from django-admin document into a new document, and
added new material.

Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
@felixxm felixxm changed the title Fixed #34054. Adds Fixtures Topic. Fixed #34054 -- Created a new fixtures topic. Nov 2, 2022
@felixxm
Copy link
Copy Markdown
Member

felixxm commented Nov 2, 2022

@filiplajszczak Thanks for updates ⭐ I pushed tiny edits.

@felixxm felixxm merged commit 6103059 into django:main Nov 2, 2022
@filiplajszczak
Copy link
Copy Markdown
Contributor Author

@felixxm Thanks, ref makes much more sense now as we have a target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants