Skip to content
/ django Public

Fixed #33753 -- Fixed docs build on Sphinx 5+.#15745

Merged
felixxm merged 1 commit intodjango:mainfrom
felixxm:issue-33753
Jun 1, 2022
Merged

Fixed #33753 -- Fixed docs build on Sphinx 5+.#15745
felixxm merged 1 commit intodjango:mainfrom
felixxm:issue-33753

Conversation

@felixxm
Copy link
Copy Markdown
Member

@felixxm felixxm commented May 31, 2022

Empty language is not supported anymore.

ticket-33753

@felixxm felixxm requested a review from a team May 31, 2022 05:10
@felixxm
Copy link
Copy Markdown
Member Author

felixxm commented May 31, 2022

@dhellmann Does it work for you?

@felixxm
Copy link
Copy Markdown
Member Author

felixxm commented May 31, 2022

I also fixed the spelling check, see sphinx-contrib/spelling#36.

Copy link
Copy Markdown
Member

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super. Thanks.

@carltongibson
Copy link
Copy Markdown
Member

Except we still have the warnings... https://github.com/django/django/runs/6665084792?check_suite_focus=true#step:5:9

🧐

@felixxm
Copy link
Copy Markdown
Member Author

felixxm commented May 31, 2022

Except we still have the warnings... https://github.com/django/django/runs/6665084792?check_suite_focus=true#step:5:9

Fixed.

Empty language is not supported anymore.
@felixxm felixxm merged commit 565ad5a into django:main Jun 1, 2022
@felixxm felixxm deleted the issue-33753 branch June 1, 2022 10:17
@dhellmann
Copy link
Copy Markdown

Thanks, @felixxm !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants